Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support UBO twitch-videoad js snippet #9027

Open
ryanbr opened this issue Apr 5, 2020 · 0 comments
Open

Support UBO twitch-videoad js snippet #9027

ryanbr opened this issue Apr 5, 2020 · 0 comments
Assignees
@antonok-edm
Labels
feature/shields/adblock reports/missing-ads webcompat

Comments

@ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Apr 5, 2020 •
edited

Description

Viewing twitch,tv with shields up /site-tracking enabled, video ads are getting through in Nightly.

Steps to Reproduce

  1. Open Nightly (tested in 1.9.4)
  2. Browse various streams. (Tested on https://www.twitch.tv/esl_csgo)
  3. In-video ad will show.

Actual result:

(sample of video ad)
twitch-ad
twitch-ad2

Expected result:

Expect no invideo ads

Reproduces how often:

May require a bit of browsing of twitch streams to replicate.

Brave version (brave://version info)

Tested in Version 1.9.4 Chromium: 81.0.4044.83 (Official Build) nightly (64-bit)

Miscellaneous Information:

uBO is using the following filter: twitch.tv##+js(twitch-videoad)

Orginal PR: https://github.com/uBlockOrigin/uAssets/pull/3517
Snippet: https://github.com/gorhill/uBlock/blob/a94df7f3b27080ae2dcb3b914ace39c0c294d2f6/assets/resources/scriptlets.js#L913
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonok-edm antonok-edm

Labels
feature/shields/adblock reports/missing-ads webcompat
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@ryanbr @antonok-edm
You can’t perform that action at this time.