Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] improving "private browsing" icon in PB mode #9071

Open
kjozwiak opened this issue Apr 7, 2020 · 2 comments
Open

[Android] improving "private browsing" icon in PB mode #9071

kjozwiak opened this issue Apr 7, 2020 · 2 comments

Comments

@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Apr 7, 2020

Description

We should make the PB icon that switches between PB/Normal lighter/white so it's easier to see. It's currently a grey icon against a dark background which makes it hard to spot. Users who don't know the functionality exists might end up missing it.

Steps to reproduce

  1. launch the latest released android-core
  2. open PB mode and you'll notice the icon in the right corner hard to see/spot

Actual result

Example of issue occurring in PB
20200407_124413

Expected result

Icon should appear white so it's easier to see while in PB mode. Users who don't know the switching functionality exists might miss the icon entirely as it's hard to see.

Issue reproduces how often

100% reproducible using the above STR.

Issue happens on

  • Current Play Store version? Yes
  • Beta build? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): Samsung Galaxy Tablet A
  • Android version: Android 9

Brave version

  • Brave-Nightly 1.9.7 CR: 81.0.4044.83

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

CCing @brave/legacy_qa @SergeyZhukovsky @bsclifton

@SergeyZhukovsky
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky commented Apr 7, 2020

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Apr 8, 2020

This was reported on tabs long back but never fixed brave/browser-android-tabs#747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Android General
  
Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.