Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Copy/Print/Save as File actions under "Backup your wallet" #929

Closed
NejcZdovc opened this issue Sep 2, 2018 · 6 comments · Fixed by brave/brave-core#816
Closed

Comments

@NejcZdovc
Copy link
Contributor

Implement copy, print and save as File in Backup/Restore dialog.

image

@NejcZdovc NejcZdovc added this to the Releasable builds 0.55.x milestone Sep 2, 2018
@bbondy bbondy added this to Brave Rewards in 0.55.x - Release Sep 9, 2018
@NejcZdovc NejcZdovc changed the title Backup your wallet Backup your wallet actions Sep 16, 2018
@bbondy
Copy link
Member

bbondy commented Sep 22, 2018

maybe we could move this to 1.0 considering a user can copy and paste the codes using cmd+c or the right click menu.

@NejcZdovc
Copy link
Contributor Author

agree

@NejcZdovc NejcZdovc modified the milestones: Releasable builds 0.55.x, 1.0 Sep 22, 2018
@bbondy bbondy removed this from Brave Rewards in 0.55.x - Release Sep 24, 2018
@bbondy bbondy added this to Rewards in 1.0 Tasks by Category Sep 29, 2018
@NejcZdovc NejcZdovc assigned jasonrsadler and unassigned ryanml Oct 1, 2018
@kjozwiak kjozwiak changed the title Backup your wallet actions Implement Copy/Print/Save as File actions under "Backup your wallet" Oct 4, 2018
@garrettr
Copy link
Contributor

maybe we could move this to 1.0 considering a user can copy and paste the codes using cmd+c or the right click menu.

Could we hide the nonfunctional buttons in the meantime? I just encountered this and was briefly perplexed. Might frustrate/unnerve some end users.

Also, might consider adding some copy saying "you can select and copy the recovery key with the Cmd-C copy keyboard shortcut." I figured that out via trial and error but it's not exactly obvious.

@NejcZdovc NejcZdovc removed this from Rewards in 1.0 Tasks by Category Oct 22, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.0, 0.57.x - Dev Oct 22, 2018
@NejcZdovc NejcZdovc added this to Backlog in Rewards Oct 30, 2018
@bbondy bbondy modified the milestones: 0.57.x - Dev, 1.x Backlog Oct 30, 2018
@mandar-brave mandar-brave added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 1, 2018
@mandar-brave mandar-brave moved this from Untriaged Backlog to P3, P4, & P5 Backlog in Rewards Nov 1, 2018
Rewards automation moved this from P3, P4, & P5 Backlog to Completed Nov 8, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.58.x - Dev Nov 8, 2018
@srirambv srirambv added the QA/Yes label Nov 9, 2018
@srirambv
Copy link
Contributor

@NejcZdovc the implemented design is different from the original spec screenshot mentioned in the issue? Can you confirm which one is to be verified?
image

@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Dec 11, 2018

@srirambv yes we changed design, what you have on the screenshoot is correct (except duplicated text)

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Dec 11, 2018

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows
  • Verified Save/Print/Save options for recover backup key

Verified passed with

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux
  • Verified text change as per spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants