Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display zero count on brave shield icon on "clean" sites #933

Closed
bsclifton opened this issue Sep 3, 2018 · 3 comments
Closed

Display zero count on brave shield icon on "clean" sites #933

bsclifton opened this issue Sep 3, 2018 · 3 comments

Comments

@bsclifton
Copy link
Member

@bsclifton bsclifton commented Sep 3, 2018

Carried over from brave/browser-laptop#11106

Description

Display zero count on brave shield icon on "clean" sites. The idea was at first brought up here:
https://community.brave.com/t/special-rewarding-ui-for-zero-shield-hit-websites/7802?u=suguru

Web users became accustomed to looking for the little lock that browser UIs reward sites using SSL with.

I’m trying to get into the habit of looking at the Brave logo on the top-right to see if there is a number there, and when there is none I try to make a mental note of “nice, this website respects me, I should be kind to them.”

I’m thinking Brave could reward sites with no ads/trackers/etc. with something special as well. Maybe add a little shine to the lion, or something that says “zero” that is not just the absence of a number.

I thought it was a nice idea and displaying something like zero count box on the shield with a green color like this should work:

clipboard01

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Sep 3, 2018

The count was shown as 0 initially when nothing was blocked but then reverted here brave/browser-laptop@29acdac for brave/browser-laptop#7873. Not sure if this is still a valid?

@bbondy
Copy link
Member

@bbondy bbondy commented Sep 3, 2018

I think I prefer no 0

@bsclifton bsclifton removed this from the 2.x Backlog milestone Sep 3, 2018
@bsclifton
Copy link
Member Author

@bsclifton bsclifton commented Sep 3, 2018

SGTM 😄 👍

@bsclifton bsclifton closed this Sep 3, 2018
@bbondy bbondy added this to the Dupe / Invalid milestone Sep 4, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.