Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign brave://settings #955

Closed
rebron opened this issue Sep 4, 2018 · 10 comments

Comments

@rebron
Copy link
Collaborator

commented Sep 4, 2018

Test plan

  1. Open brave://settings
  2. Check look and feel page
    • are highlighted elements orange?
    • do the icons look like ours?
    • is the font Poppins?

Description

Add/remove/reorganize Brave settings and use new styling.

Expected result

Make Brave settings more intuitive and consistent with Brave look and feel.

Design

Not current/to be updated
df6efe0b-1fec-459f-9f83-dd8fb460a3d8 1

@rebron rebron added this to the 1.0 milestone Sep 4, 2018

@srirambv

This comment has been minimized.

Copy link
Collaborator

commented Sep 5, 2018

@bradleyrichter @rebron Reset Settings has printer icon in the updated specs. should be updated

@rebron

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 5, 2018

@srirambv Good catch, I'll get that updated. It'll be the same reset icon in the sidebar.

@beenotung

This comment has been minimized.

Copy link

commented Oct 5, 2018

I have got used to the current layout, wish this update doesn't come soon ...

@mil1i

This comment has been minimized.

Copy link

commented Oct 17, 2018

I would love to see the Appearance section have an option (and obviously the ability to) make the Open Tabs, Address Bar + Buttons and Bookmarks Bar different sizes. Preferably Compact.

As can be seen in the photo below, firefox I can have all 3 enabled and it cuts off where the Booksmarks Bar begins in Brave/Chrome.

browser-bar

@Jacalz

This comment has been minimized.

Copy link
Collaborator

commented Oct 26, 2018

This looks really sweet, good job! 👍

@bbondy bbondy modified the milestones: 1.0, 1.x Backlog Oct 30, 2018

@rebron rebron added this to Untriaged Backlog in Front End Nov 5, 2018

@rebron rebron moved this from Untriaged Backlog to Prioritized Backlog in Front End Dec 4, 2018

@rebron rebron removed this from Settings and chrome:// pages in 1.0 Tasks by Category Jan 15, 2019

@rebron rebron removed this from Prioritized Backlog in Front End Jan 15, 2019

@rebron rebron added this to In progress in Settings Jan 15, 2019

@rebron rebron added the priority/P2 label Jan 15, 2019

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019

@AlexeyBarabash

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

Not sure, should it be here or be in a separate issue, but I see the overlapped controls on brave://bookmarks page

image

Nightly master, Linux

Brave 0.63.0 Chromium: 73.0.3683.39 (Developer Build) (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Linux

@petemill petemill referenced this issue Mar 12, 2019

Merged

WebUI: Settings & 4 different ways to override #1909

9 of 19 tasks complete

@bsclifton bsclifton removed their assignment Mar 19, 2019

@bsclifton bsclifton added this to the 0.64.x - Nightly milestone Mar 19, 2019

@bsclifton bsclifton added the QA/Yes label Mar 19, 2019

@srirambv

This comment has been minimized.

Copy link
Collaborator

commented Apr 4, 2019

@bsclifton @petemill once this reorganize/redesign of settings page is done I believe the side bar menu would be fixed? If so opening extensions page would hide the side bar and just show the existing extensions side bar options ?
image

User from https://community.brave.com/t/no-custom-keyboard-shortcuts-via-extensions-menu/51913 says the side bar menu on extensions page is missing so he is unable to access the keyboard shortcut option there.

@rebron

This comment has been minimized.

Copy link
Collaborator Author

commented May 21, 2019

@rossmoody mocks/spec to be updated to reflect decisions made by product and design during course of implementation.

@srirambv

This comment has been minimized.

Copy link
Collaborator

commented May 27, 2019

@petemill @rebron Couple of observations

  • Only selected item icon is Orange and the text isn't bold. Is this expected?
  • Should hover over settings sidebar have visual feedback

@rebron rebron changed the title Add/Remove/Reorganize Settings and use new styling Redesign brave://settings May 28, 2019

@srirambv

This comment has been minimized.

Copy link
Collaborator

commented May 28, 2019

Verification passed on

Brave 0.65.112 Chromium: 75.0.3770.38 (Official Build) beta(64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Linux

Verification passed on

Brave 0.65.112 Chromium: 75.0.3770.38 (Official Build) beta (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verification PASSED on macOS 10.14.5 x64 using the following build:

Brave 0.65.113 Chromium: 75.0.3770.38 (Official Build) beta(64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Mac OS X
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.