Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP SI images are visible for every NTP after terminating SR component #9716

Open
simonhong opened this issue May 11, 2020 · 0 comments · May be fixed by brave/brave-core#5510
Open

NTP SI images are visible for every NTP after terminating SR component #9716

simonhong opened this issue May 11, 2020 · 0 comments · May be fixed by brave/brave-core#5510

Comments

@simonhong
Copy link
Collaborator

@simonhong simonhong commented May 11, 2020

Description

When SR campaign is ended, SI images are visible for every NTP.
However, NTP should show SI images for every 4th NTP.
This behavior is fixed after restarting or SI component is updated.

Steps to Reproduce

  1. Launch Browser with SR code
  2. Check NTP shows SR images
  3. Terminate current SR campaign
  4. Update SR component via brave://components
  5. Check how often SI images are visible

Actual result:

SI images are visible for every tab

Expected result:

SI images are visible for every 4th tab

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@simonhong simonhong added this to the 1.10.x - Nightly milestone May 11, 2020
@simonhong simonhong self-assigned this May 11, 2020
@simonhong simonhong linked a pull request that will close this issue May 11, 2020
9 of 32 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.