Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested site and history suggested link shows up as duplicate #9719

Open
srirambv opened this issue May 11, 2020 · 0 comments
Open

Suggested site and history suggested link shows up as duplicate #9719

srirambv opened this issue May 11, 2020 · 0 comments

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented May 11, 2020

Description

Suggested site and visited link shows up as duplicate

Steps to Reproduce

  1. Install dev 1.9.61
  2. Type BTC in URL bar
  3. Select Brave suggested link and wait for the page to load
  4. Close tab and open new tab
    5. Type BTC the suggested site and visited site both show up making it a duplicate entry

Actual result:

The only way to differentiate is the highlighted text in one of the entry
Screen Shot 2020-05-11 at 12 29 57 PM

Expected result:

Only show Brave suggested site if the user has visited the link and has it as a history suggestion

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.9.61 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{# 999}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

Found while testing #9302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Crypto Wallets
  
Awaiting triage
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.