Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video playback not being shown on https://next.brella.io/events/consensusdistributed/stream #9729

Open
ryanbr opened this issue May 12, 2020 · 2 comments

Comments

@ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented May 12, 2020

Description

Video playback not being shown on https://next.brella.io/events/consensusdistributed/stream

Steps to Reproduce

  1. Signup via https://www.coindesk.com/events/consensus-2020
  2. Click on CONSENSUS: DISTRIBUTED
  3. Visit https://next.brella.io/events/consensusdistributed/stream
  4. Expect video to playback

Actual result:

No video playback due to cookies.

Expected result:

Video playback.

Reproduces how often:

Easily, Need to Allow all cookies to get around issue.

Brave version (brave://version info)

Version 1.8.95 Chromium: 81.0.4044.138 (Official Build) (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

Allow all cookies for .brella.io/ is needed. Blocking cookies for coinbase.com is preventing the video from showing

brella-coinbase

@pes10k
Copy link
Contributor

@pes10k pes10k commented May 12, 2020

caused by #9729

@pes10k
Copy link
Contributor

@pes10k pes10k commented May 12, 2020

As noted in Slack:

The culprit here is localStorage and sessionStorage throwing when touched

and

(i) un-bust chromium’s odd solution to throw when touching window.{local,session}Storage (instead of just leaving it undefined, for feature detection) and
(ii) mock those endpoints out with similar looking, in-memory storage Storage-likes

and

the way more trick, but middle term solution is to do dual keyed storage, and then re-enable these again, but thats going to take some signifigant plumbing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.