Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Welcome modal should no longer show if chrome.braveWallet.loadUI is available. #9753

Closed
ryanml opened this issue May 12, 2020 · 0 comments
Closed

Welcome modal should no longer show if chrome.braveWallet.loadUI is available. #9753

ryanml opened this issue May 12, 2020 · 0 comments
Assignees
@ryanml
Labels
QA/Yes feature/crypto-wallets
Milestone
1.10.x - Beta

Comments

@ryanml
Copy link
Member

@ryanml ryanml commented May 12, 2020

As the disclosure statement is now a WebUI interface under brave://wallet, after clicking I understand users should not see the welcome modal again once the Crypto Wallets extension loads.

Test Plan

  1. Start Brave with a clean profile
  2. Navigate to brave://wallet
  3. Click I understand, prompting page reload.
  4. Ensure that the welcome modal containing that original disclosure statement is not present.
@ryanml ryanml added this to the 1.10.x - Nightly milestone May 12, 2020
@ryanml ryanml self-assigned this May 12, 2020
@ryanml ryanml mentioned this issue May 12, 2020
Merged
@ryanml ryanml reopened this May 12, 2020
@ryanml ryanml closed this May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
QA/Yes feature/crypto-wallets
Projects
None yet
Milestone
  1.10.x - Beta
Linked pull requests

Successfully merging a pull request may close this issue.

Don't show welcome modal when loadUI is available.
1 participant
@ryanml
You can’t perform that action at this time.