Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw when accessing local,sessionStorage in 3p frame #9758

Open
pes10k opened this issue May 12, 2020 · 1 comment
Open

Don't throw when accessing local,sessionStorage in 3p frame #9758

pes10k opened this issue May 12, 2020 · 1 comment

Comments

@pes10k
Copy link
Contributor

@pes10k pes10k commented May 12, 2020

Currently, Chromium throws an exception when JS just touches window.{local,session}Storage, which prevents sites from doing typical feature detection style checks. We should just act as if these values aren't present (e.g. window.localStorage === undefined|null) so that defensive / well programmed sites still work correctly

@pes10k
Copy link
Contributor Author

@pes10k pes10k commented May 12, 2020

This is related to #8514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.