Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upyarn test #100
Merged
yarn test #100
Conversation
|
++, thanks! |
|
<3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
garrettr commentedMar 14, 2018
Adds a
yarn testcommand to build and run unit tests. Requires a<suite>argument with the name of the test target to build and run.This PR accompanies brave/brave-core#57 and is meant to provide a convenient wrapper for building and running the tests, in the manner of
yarn build,yarn start, etc.Example (using brave/brave-core#57):
Remaining work
--gtest-filter.Some of the Chromium test suites are enormous (e.g.
unit_tests) and it is very helpful to have--gtest-filterwhen working with them. Support for--gtest-filtercould be added in this PR or in a follow-up.