Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default config so ninja is in PATH #101

Merged
merged 1 commit into from Mar 14, 2018
Merged

Use default config so ninja is in PATH #101

merged 1 commit into from Mar 14, 2018

Conversation

@bbondy
Copy link
Member

bbondy commented Mar 14, 2018

config.defaultOptions contains an env which doesn't require ninja to be in your path. It already also includes both of these properties:

{
   stdio: 'inherit',
   shell: true
}

Without this PR, you'd need to have PATH="$PATH:/path/to/brave/vendor/depot_tools".

@bbondy bbondy self-assigned this Mar 14, 2018
@bbondy bbondy requested a review from garrettr Mar 14, 2018
@garrettr
Copy link
Contributor

garrettr commented Mar 14, 2018

Good catch! I should've tested #100 with an unmodified $PATH.

@garrettr garrettr merged commit 5c24ad7 into master Mar 14, 2018
@cezaraugusto cezaraugusto deleted the default-config-tests branch Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.