Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCleanup for #229 #300
Merged
Cleanup for #229 #300
Conversation
* Set build target through the config for create_dist * check config.gClientVerbose directly * change lib/util methood buildMuon to buildCore
Was supposed to be fixed in #229 but lost a few commits. We fix the snakecasing done by commander.js there but don't set the ref correctly because the name differs from what is set by lib/config.js. This adds a parameter to the projects config to specify what should be used for the command line arg (defaults to name.replace('-', '_'). Fixes #299
|
@bridiver you mind taking a look at this? |
| @@ -176,7 +176,8 @@ Config.prototype.buildProjects = function () { | |||
| url: getNPMConfig(['projects', projectName, 'repository', 'url']), | |||
| gclientName: getNPMConfig(['projects', projectName, 'dir']), | |||
| dir: path.join(this.rootDir, getNPMConfig(['projects', projectName, 'dir'])), | |||
| custom_deps: packages.config.projects[projectName].custom_deps | |||
| custom_deps: packages.config.projects[projectName].custom_deps, | |||
| arg_name: projectName.replace('-', '_') | |||
This comment has been minimized.
This comment has been minimized.
bridiver
Jun 18, 2018
Collaborator
maybe just name? arg_ was a little confusing to me. Just a nit though.
This comment has been minimized.
This comment has been minimized.
RyanJarv
Jun 18, 2018
Author
Contributor
Didn't want it to get confused with the actual name since the original name is still being used in other places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
RyanJarv commentedJun 7, 2018
•
edited
Few things to clean up post #229 merge
yarn run sync --<project>_ref=commandSubmitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Just manually right now across various machines (which is likely why so many bugs are getting missed here). Have this ticket open for adding testing to the build tools in general #304.
Reviewer Checklist: