Issue 4030: Using SIGKILL instead of SIGTERM to terminate the process on timeout

[jumde]

fix #4030

PR Builder passed here: https://staging.ci.brave.com/job/brave-browser-build-pr/job/PR-4036/4/

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Windows
  • macOS
  • Linux
• Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
  • Windows
  • macOS
  • Linux
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Requested a security/privacy review as needed.

Test Plan:

1. Verify that npm run test-security works on build machines.
2. Remove any entry from lib/whitelistedUrlPrefixes.js and confirm it fails.

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions.

[mihaiplesa]

We could try SIGTERM first and then SIGKILL (1m after), what do you all think?

[diracdeltas]

We could try SIGTERM first and then SIGKILL (1m after), what do you all think?

that sgtm. or add an env variable for the build machines which need SIGKILL

[jumde]

We could try SIGTERM first and then SIGKILL (1m after), what do you all think?

that sgtm. or add an env variable for the build machines which need SIGKILL

I'll add an environment variable.

@mihaiplesa: let me know if BUILD_MACHINE=yes sounds good as the env variable and value?

EDIT: Updated @mihaiplesa @diracdeltas - let me know if the code looks good now

[mihaiplesa]

We have a var named RELEASE_TYPE, if that is set it's an indication you're in a build machine (it gets values of release and ci) so we should use this instead.

[mihaiplesa]

have tested and works as expected

change she requested as made with 7ef06af