Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium "74.0.3729.108" to Chromium 74.0.3729.131 #4281

Merged
merged 1 commit into from May 2, 2019
Merged

Upgrade from Chromium "74.0.3729.108" to Chromium 74.0.3729.131 #4281

merged 1 commit into from May 2, 2019

Conversation

@bsclifton
Copy link
Member

bsclifton commented May 1, 2019 •
edited

Fixes #4278
Related brave/brave-core#2353
@brave-browser-releases
Upgrade from Chromium "74.0.3729.108" to Chromium 74.0.3729.131
Loading status checks…
69f415d
@bsclifton bsclifton requested review from emerick and mkarolin May 1, 2019
@bsclifton bsclifton self-assigned this May 1, 2019
@bsclifton bsclifton added this to the 0.66.x - Nightly milestone May 1, 2019
@emerick
emerick reviewed May 1, 2019
View changes
Copy link
Contributor

emerick left a comment

LGTM
@brave brave deleted a comment from andhie76 May 2, 2019
@bsclifton bsclifton force-pushed the 74.0.3729.131_master_22 branch from 06c9c65 to 69f415d May 2, 2019
@bsclifton
Copy link
Member Author

bsclifton commented May 2, 2019

OK folks - CI is in good shape (in my opinion)! We got the code building and tests passing (results can be seen at https://staging.ci.brave.com/job/brave-browser-build-pr/job/PR-4281/5/). npm run test-security does fail, but that is not related to this (issue captured with brave/sync#307 - we can resolve before official builds)
@emerick
emerick approved these changes May 2, 2019
View changes
Copy link
Contributor

emerick left a comment

LGTM
@bsclifton bsclifton merged commit 31bea95 into master May 2, 2019
1 check was pending
1 check was pending
continuous-integration/jenkins/pr-head This commit is scheduled to be built
Details
@bsclifton bsclifton deleted the 74.0.3729.131_master_22 branch May 2, 2019
@bsclifton bsclifton mentioned this pull request May 2, 2019
Merged
bsclifton added a commit that referenced this pull request May 2, 2019
@bsclifton
Merge pull request #4281 from brave/74.0.3729.131_master_22
Unverified
This user has not uploaded their public key yet.
GPG key ID: 37FF5F19022427F2 Learn about signing commits
Loading status checks…
8bab899 
Upgrade from Chromium "74.0.3729.108" to Chromium 74.0.3729.131
bsclifton added a commit that referenced this pull request May 2, 2019
@bsclifton
Merge pull request #4281 from brave/74.0.3729.131_master_22
Unverified
This user has not uploaded their public key yet.
GPG key ID: 37FF5F19022427F2 Learn about signing commits
Loading status checks…
e37afe9 
Upgrade from Chromium "74.0.3729.108" to Chromium 74.0.3729.131
bsclifton added a commit that referenced this pull request May 2, 2019
@bsclifton
Merge pull request #4281 from brave/74.0.3729.131_master_22
Unverified
This user has not uploaded their public key yet.
GPG key ID: 37FF5F19022427F2 Learn about signing commits
Loading status checks…
2066b27 
Upgrade from Chromium "74.0.3729.108" to Chromium 74.0.3729.131
This was referenced May 2, 2019
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick

@mkarolin mkarolin

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
  0.66.x - Release ...
Linked issues

Successfully merging this pull request may close these issues.

Upgrade from Chromium 74.0.3729.108 to 74.0.3729.131
3 participants
@bsclifton @emerick @brave-browser-releases
You can’t perform that action at this time.