Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upwarn patch maintainer to remove patch #50
Merged
Conversation
|
|
lib/updatePatches.js
Outdated
| console.log('updatePatches writing files to: ' + patchDir) | ||
|
|
||
| // grab Modified (and later Deleted) files but not Created (since we copy those) | ||
| const modifiedDiffArgs = ['diff', '--diff-filter=M', '--name-only', '--ignore-space-at-eol'] | ||
| let modifiedDiff = util.run('git', modifiedDiffArgs, runOptions) | ||
| let moddedFileList = modifiedDiff.stdout.toString().split('\n').filter(s => s.length > 0) | ||
| let modifiedDiff = util.run('git', modifiedDiffArgs, runOptionsChrome) |
This comment has been minimized.
This comment has been minimized.
bridiver
Jan 9, 2018
Collaborator
can we split some of this out into separate methods in a follow-up?
|
Rebased, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kevinlawler commentedJan 8, 2018
brave/brave#49