Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Build: Only fail when versions mismatch in CI #5104

Open
wants to merge 2 commits into
base: master
from
Open
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

Build: Only fail when versions mismatch in CI

  • Loading branch information
petemill committed Jul 2, 2019
commit d3962f2785a7c03282499e94cbd8409db04182b3
@@ -3,6 +3,8 @@ const util = require('../lib/util')
const path = require('path')
const fs = require('fs-extra')

const isCIEnvironment = !!process.env.CI

const touchOverriddenFiles = () => {
console.log('touch original files overridden by chromium_src...')

@@ -81,7 +83,7 @@ const checkVersionsMatch = () => {
const braveVersionFromChromeFile = `${found[2]}.${found[3]}.${found[4]}`
if (braveVersionFromChromeFile !== config.braveVersion) {
console.warn(`Version files do not match!\nsrc/chrome/VERSION: ${braveVersionFromChromeFile}\nbrave-browser package.json version: ${config.braveVersion}`)
if (config.buildConfig === 'Release') {
if (isCIEnvironment) {
process.exit(1)
}
}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.