Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintain: const over let, consistency #5494

Open
wants to merge 6 commits into
base: master
from
Open
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Merge branch 'master' into maintenance

  • Loading branch information
kmdrGroch committed Nov 21, 2019
commit 32d19a174ca492772693b49eb564fb0148f7c13a
@@ -2,7 +2,21 @@ const config = require('../lib/config')
const util = require('../lib/util')
const {braveTopLevelPaths, ethereumRemoteClientPaths} = require('./l10nUtil')

const pullL10n = () => {

This comment has been minimized.

Copy link
@petemill

petemill Dec 5, 2019

Member

Please remove this extra line 😄

const pullL10n = (options) => {
const cmdOptions = config.defaultOptions
cmdOptions.cwd = config.projects['brave-core'].dir
if (options.extension) {
if (options.extension === 'ethereum-remote-client') {
ethereumRemoteClientPaths.forEach((sourceStringPath) => {
util.run('python', ['script/pull-l10n.py', '--source_string_path', sourceStringPath], cmdOptions)
})
return
}
console.error('Unknown extension: ', options.extension)
process.exit(1)
}

braveTopLevelPaths.forEach((sourceStringPath) => {
util.run('python', ['script/pull-l10n.py', '--source_string_path', sourceStringPath], cmdOptions)
})
@@ -2,8 +2,7 @@ const config = require('../lib/config')
const util = require('../lib/util')
const {braveTopLevelPaths, ethereumRemoteClientPaths} = require('./l10nUtil')

const pushL10n = () => {
// Get rid of local copied xtb and grd changes
const pushL10n = (options) => {
const runOptions = { cwd: config.projects.chrome.dir }
const cmdOptions = config.defaultOptions
cmdOptions.cwd = config.projects['brave-core'].dir
You are viewing a condensed version of this merge commit. You can view the full changes here.
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.