Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npmrc: Force `package-lock=true` option #5560

Open
wants to merge 1 commit into
base: master
from
Open
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

npmrc: Force package-lock=true option

It's relatively common for folks who primarily develop npm packages (rather than top-level apps) to disable the creation of package-lock.json files as they're not useful for package development.

This commit just forces this option to `true` so that the browser build works correctly for these users (including myself).

Sidenote: Why is package-lock.json not useful to package authors? Lock files don't get published to npm so users will always get the latest versions that semver allows, so it's good for package authors to have the same experience. Otherwise, package-lock.json can obscure that a package is actually broken.
  • Loading branch information
feross authored and brave-browser-releases committed Aug 6, 2019
commit db427a6a6e8846a8689b070486efe8389884de82
1 .npmrc
@@ -2,3 +2,4 @@ brave_product_name = Brave
brave_project_name = brave
dist_url = https://brave-brave-binaries.s3.amazonaws.com/releases/dist/
BRAVE_S3_BUCKET = brave-brave-binaries
package-lock=true
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.