Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd create_dist script #57
Merged
Conversation
lib/createDist.js
Outdated
|
|
||
| const createDist = (options) => { | ||
| config.update(options) | ||
| config.buildConfig = 'Release' |
This comment has been minimized.
This comment has been minimized.
bridiver
Jan 17, 2018
Collaborator
do we need to force a buildConfig here? I know it's in muon, but that might actually be making things harder for people
|
++ |
bbondy
force-pushed the
create_dist
branch
3 times, most recently
from
7a1db9d
to
8bd8113
cezaraugusto
pushed a commit
that referenced
this pull request
May 15, 2018
Groundwork for Brave tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bbondy commentedJan 16, 2018
No description provided.