Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWIP: Upgrade from Chromium 76.0.3809.132 to Chromium 77.0.3865.56 #5840
Conversation
This was referenced Aug 30, 2019
mkarolin
force-pushed the
77.0.3865.56
branch
3 times, most recently
from
f42a2a1
to
028ec50
manifest_package is now chrome_public_manifest_package. Chromium change: https://chromium.googlesource.com/chromium/src/+/5172118ff57bef7dd2864c9fe891db9c05f76a2b commit 5172118ff57bef7dd2864c9fe891db9c05f76a2b Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Mon Jun 24 21:57:47 2019 +0000 [build] Add ability to define manifest package in GN The build system will verify that the manifest packages match if you specify it in both GN and the manifest. Bug: 891996
|
Closing in favor of #5896 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mkarolin commentedAug 30, 2019
•
edited
Fixes #5375
Related PR: brave/brave-core#3304
Submitter Checklist:
git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.