Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes lint script. #5972
Merged
Fixes lint script. #5972
Conversation
Fixes #5971 Removed auth_config from our script as we don't need to pass it to devtools script any more. The failure is due to devtools change: commit 934836a6c5b1a3442db7f7197569fc1bbdcb8991 [log] [tgz] author Edward Lemur <ehmaldonado@chromium.org> Mon Sep 09 20:16:54 2019 committer Commit Bot <commit-bot@chromium.org> Mon Sep 09 20:16:54 2019 tree c6cb985aca378a2f816bb7d21a072394b1d4882a parent 1e4d70d1dd0865b0ac824beccee70d3852705dd8 [diff] git-cl: Remove unused auth configs. auth_config is a Rietveld thing, so it's not necessary in most of the code, except for triggering try bots. Bug: 1001756 Change-Id: I0f243a297b05a43a61b052ba75c5886556e81b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1793018
|
Passed lint step in CI on all platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mkarolin commentedSep 10, 2019
•
edited
Fixes #5971
Removed auth_config from our script as we don't need to pass it to
devtools script any more.
The failure is due to devtools change:
commit 934836a6c5b1a3442db7f7197569fc1bbdcb8991 [log] [tgz]
author Edward Lemur ehmaldonado@chromium.org Mon Sep 09 20:16:54 2019
committer Commit Bot commit-bot@chromium.org Mon Sep 09 20:16:54 2019
tree c6cb985aca378a2f816bb7d21a072394b1d4882a
parent 1e4d70d1dd0865b0ac824beccee70d3852705dd8 [diff]
git-cl: Remove unused auth configs.
auth_config is a Rietveld thing, so it's not necessary
in most of the code, except for triggering try bots.
Bug: 1001756
Change-Id: I0f243a297b05a43a61b052ba75c5886556e81b4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1793018
Submitter Checklist:
git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.