Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes lint script. #5972

Merged
merged 1 commit into from Sep 10, 2019
Merged

Fixes lint script. #5972

merged 1 commit into from Sep 10, 2019

Conversation

@mkarolin
Copy link
Contributor

mkarolin commented Sep 10, 2019

Fixes #5971

Removed auth_config from our script as we don't need to pass it to
devtools script any more.

The failure is due to devtools change:

commit 934836a6c5b1a3442db7f7197569fc1bbdcb8991 [log] [tgz]
author Edward Lemur ehmaldonado@chromium.org Mon Sep 09 20:16:54 2019
committer Commit Bot commit-bot@chromium.org Mon Sep 09 20:16:54 2019
tree c6cb985aca378a2f816bb7d21a072394b1d4882a
parent 1e4d70d1dd0865b0ac824beccee70d3852705dd8 [diff]
git-cl: Remove unused auth configs.

auth_config is a Rietveld thing, so it's not necessary
in most of the code, except for triggering try bots.

Bug: 1001756
Change-Id: I0f243a297b05a43a61b052ba75c5886556e81b4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1793018

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
Fixes #5971

Removed auth_config from our script as we don't need to pass it to
devtools script any more.

The failure is due to devtools change:

commit	934836a6c5b1a3442db7f7197569fc1bbdcb8991	[log] [tgz]
author	Edward Lemur <ehmaldonado@chromium.org>	Mon Sep 09 20:16:54 2019
committer	Commit Bot <commit-bot@chromium.org>	Mon Sep 09 20:16:54 2019
tree	c6cb985aca378a2f816bb7d21a072394b1d4882a
parent	1e4d70d1dd0865b0ac824beccee70d3852705dd8 [diff]
git-cl: Remove unused auth configs.

auth_config is a Rietveld thing, so it's not necessary
in most of the code, except for triggering try bots.

Bug: 1001756
Change-Id: I0f243a297b05a43a61b052ba75c5886556e81b4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1793018
@mkarolin mkarolin added this to the 0.72.x - Nightly milestone Sep 10, 2019
@mkarolin mkarolin self-assigned this Sep 10, 2019
@mkarolin
Copy link
Contributor Author

mkarolin commented Sep 10, 2019

Passed lint step in CI on all platforms.

@mkarolin mkarolin requested review from bridiver and bsclifton Sep 10, 2019
@mkarolin mkarolin merged commit 59c9b6e into master Sep 10, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-head This commit looks good
Details
@mkarolin mkarolin deleted the maxk-fix-lint-script branch Sep 10, 2019
mkarolin added a commit that referenced this pull request Sep 11, 2019
Fixes lint script.
mkarolin added a commit that referenced this pull request Sep 11, 2019
Fixes lint script.
bsclifton added a commit that referenced this pull request Sep 11, 2019
Fixes lint script.
mkarolin added a commit that referenced this pull request Sep 14, 2019
mkarolin added a commit that referenced this pull request Sep 15, 2019
Fixes lint script.
bsclifton added a commit that referenced this pull request Sep 17, 2019
Fixes lint script.
bsclifton added a commit that referenced this pull request Sep 17, 2019
Fixes lint script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.