Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upoverride cc files during compilation #69
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
These lines become redundant, I guess it should be possible to still use sccache or ccache even with the wrapper too. |
cezaraugusto
pushed a commit
that referenced
this pull request
May 15, 2018
Add brave payments item to app menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
AlexeyBarabash commentedFeb 9, 2018
•
edited
This is one of PRs for https://github.com/brave/brave/issues/60 .
Related Antimuon PR is brave/brave-core#33 .
It defines cc_wrapper as a script which redirects compiler to use file from brave/chromium_src if available.
Antimuon branch is changed to
override_cc. It will be required to switch it back to master after merge.