Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve test macos install step #7099

Merged
merged 5 commits into from Nov 27, 2019
Merged

improve test macos install step #7099

merged 5 commits into from Nov 27, 2019

Conversation

@linhkikuchi
Copy link
Collaborator

linhkikuchi commented Nov 26, 2019

Closes brave/devops/#2210

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
Linh Nguyen
@linhkikuchi linhkikuchi requested review from mihaiplesa and mbacchi Nov 27, 2019
@linhkikuchi linhkikuchi merged commit a1c762d into master Nov 27, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-head This commit looks good
Details
@linhkikuchi linhkikuchi deleted the test-macos-install-fix branch Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.