Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install pywin32 into depot_tools's python. #7333

Merged
merged 1 commit into from Dec 12, 2019
Merged

Install pywin32 into depot_tools's python. #7333

merged 1 commit into from Dec 12, 2019

Conversation

@mkarolin
Copy link
Contributor

mkarolin commented Dec 11, 2019

depot_tools is currently missing pywin32 on Windows which is needed
by build/toolchain/win/tool_wrapper.py.

Fixes: #7328

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
depot_tools is currently missing pywin32 on Windows which is needed
by build/toolchain/win/tool_wrapper.py.

Fixes #7328
@mkarolin mkarolin force-pushed the maxk-fix-pywin32 branch from a8e8f2e to 01ccdbe Dec 12, 2019
@mkarolin
Copy link
Contributor Author

mkarolin commented Dec 12, 2019

CI passed: MacOS failed in the first job for an unrelated reason. MacOS succeeded in the second job.

@mkarolin mkarolin changed the title WIP: Install pywin32 into depot_tools's python. Install pywin32 into depot_tools's python. Dec 12, 2019
@mkarolin mkarolin requested review from bsclifton, jumde and mbacchi Dec 12, 2019
Copy link
Member

bsclifton left a comment

++ LGTM! (tested and it works great)

@bsclifton
Copy link
Member

bsclifton commented Dec 12, 2019

NOTE: this only happens during init. Output looks like this:

Manually installing pywin32 python module
C:\brave-browser: python -m pip install pywin32
DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
Collecting pywin32
  Downloading https://files.pythonhosted.org/packages/a2/e6/6b395ea8bc9500158adea646e28077adb7f3d9587c681fd5d03693a4b5dc/pywin32-227-cp27-cp27m-win_amd64.whl (7.4MB)
Installing collected packages: pywin32
Successfully installed pywin32-227
@bsclifton bsclifton merged commit 2eaaf5d into master Dec 12, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-head This commit looks good
Details
@bsclifton bsclifton deleted the maxk-fix-pywin32 branch Dec 12, 2019
mkarolin added a commit that referenced this pull request Dec 12, 2019
Install pywin32 into depot_tools's python.
mkarolin added a commit that referenced this pull request Dec 12, 2019
Install pywin32 into depot_tools's python.
mkarolin added a commit that referenced this pull request Dec 12, 2019
Install pywin32 into depot_tools's python.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.