Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInstall pywin32 into depot_tools's python. #7333
Merged
Conversation
|
CI passed: MacOS failed in the first job for an unrelated reason. MacOS succeeded in the second job. |
|
++ LGTM! (tested and it works great) |
|
NOTE: this only happens during
|
mkarolin
added a commit
that referenced
this pull request
Dec 12, 2019
Install pywin32 into depot_tools's python.
mkarolin
added a commit
that referenced
this pull request
Dec 12, 2019
Install pywin32 into depot_tools's python.
mkarolin
added a commit
that referenced
this pull request
Dec 12, 2019
Install pywin32 into depot_tools's python.
This was referenced Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mkarolin commentedDec 11, 2019
•
edited
depot_tools is currently missing pywin32 on Windows which is needed
by build/toolchain/win/tool_wrapper.py.
Fixes: #7328
Submitter Checklist:
git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.