Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symbol_level is set to 1 for x86 Linux #76

Merged
merged 2 commits into from Apr 20, 2018

Conversation

@AlexeyBarabash
Copy link
Contributor

AlexeyBarabash commented Feb 14, 2018

With default symbol_level=2 x86 brave binary reached 6.4 GiB, this is beyond ELF32 can handle and the next steps had failed.

@AlexeyBarabash AlexeyBarabash requested review from bridiver and bbondy Feb 14, 2018
@bridiver
Copy link
Collaborator

bridiver commented Feb 14, 2018

strange, do you know why we are hitting this and chrome isn't?

@AlexeyBarabash
Copy link
Contributor Author

AlexeyBarabash commented Feb 14, 2018

@bridiver if chrome runs with the same args.gn, it does hit this issue

$ ninja -C out_x86/Release chrome/installer/linux
ninja: Entering directory `out_x86/Release'
[1/45] ACTION //chrome/installer/linux:strip_chrome_binary(//build/toolchain/linux:clang_x86)
./../../third_party/eu-strip/bin/eu-strip: illformed file 'chrome'
[9/32] ACTION //chrome/installer/linux:stable_deb(//build/toolchain/linux:clang_x86)
FAILED: chromium-browser-stable_66.0.3345.0-1_i386.deb 
python ../../build/gn_run_binary.py installer/debian/build.sh -a ia32 -b . -c stable -d chromium -o . -s ../../build/linux/debian_stretch_i386-sysroot -t linux
Expected permissions on chrome to be 644, but they were 755
installer/debian/build.sh failed with exit code 1
[10/32] ACTION //chrome/installer/linux:unstable_deb(//build/toolchain/linux:clang_x86)
FAILED: chromium-browser-unstable_66.0.3345.0-1_i386.deb 
python ../../build/gn_run_binary.py installer/debian/build.sh -a ia32 -b . -c unstable -d chromium -o . -s ../../build/linux/debian_stretch_i386-sysroot -t linux
Expected permissions on chrome to be 644, but they were 755
installer/debian/build.sh failed with exit code 1
[11/32] ACTION //chrome/installer/linux:beta_deb(//build/toolchain/linux:clang_x86)
FAILED: chromium-browser-beta_66.0.3345.0-1_i386.deb 
python ../../build/gn_run_binary.py installer/debian/build.sh -a ia32 -b . -c beta -d chromium -o . -s ../../build/linux/debian_stretch_i386-sysroot -t linux
Expected permissions on chrome to be 644, but they were 755
installer/debian/build.sh failed with exit code 1
[12/32] ACTION //chrome/installer/linux:calculate_rpm_dependencies(//build/toolchain/linux:clang_x86)
ninja: build stopped: subcommand failed.

They do even have a parameter to ignore some assertions:

ignore_elf32_limitations
    Current value (from the default) = false
      From //build_overrides/build.gni:41

    Android 32-bit non-component, non-clang builds cannot have symbol_level=2
    due to 4GiB file size limit, see https://crbug.com/648948.
    Set this flag to true to skip the assertion.

and https://crbug.com/648948 mention with details

@bbondy
bbondy approved these changes Apr 16, 2018
@bbondy
Copy link
Member

bbondy commented Apr 16, 2018

@AlexeyBarabash could you rebase and then we can merge. Sorry for the delay.

@AlexeyBarabash AlexeyBarabash merged commit 34db500 into master Apr 20, 2018
@cezaraugusto cezaraugusto deleted the x86_linux_package_sym_level_1 branch Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.