Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDo not iterate through GRDs for every single script and lib #7801
+168
−162
Conversation
Anything which required Util was also in turn requiring l10nUtil, which performs computations in the module root and has some expectations as to the state of the source tree. This isn't ideal for scripts which run at any time. Whilst the perfect fix would be exporting this functionality as a function to be run on-demand and not in the module root, the fix in this commit reduces the time this occurs by removing the require from Util.js and therefore every other lib and script
|
LGTM |
|
LGTM too! |
|
LGTM, thanks! |
|
This failed during macOS test-install phase:
|
|
Looks like CI timed out though most or all steps passed?! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
petemill commentedJan 17, 2020
Anything which required Util was also in turn requiring l10nUtil, which performs computations in the module root and has some expectations as to the state of the source tree. This isn't ideal for scripts which run at any time. Whilst the perfect fix would be exporting this functionality as a function to be run on-demand and not in the module root, the fix in this commit reduces the time this occurs by removing the require from Util.js and therefore every other lib and script.
Fix #7800
Submitter Checklist:
git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Build should start fine (first few moments is when updateBranding is run)
Reviewer Checklist:
After-merge Checklist:
changes has landed on.