Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fixes l10nUtil to not run when unneeded. #8471

Open
wants to merge 1 commit into
base: master
from

Conversation

@mkarolin
Copy link
Contributor

mkarolin commented Feb 28, 2020

Fixes #7800

Moved all top level const values consumed by other scripts into
functions.

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
Fixes #7800

Moved all top level const values consumed by other scripts into
functions.
@mkarolin mkarolin added this to the 1.7.x - Nightly milestone Feb 28, 2020
@mkarolin mkarolin self-assigned this Feb 28, 2020
@mkarolin
Copy link
Contributor Author

mkarolin commented Feb 29, 2020

@petemill, would appreciate your input on this, when you get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.