Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uppass real cc_wrapper in env var #89
Merged
Conversation
bridiver
referenced
this pull request
in brave/brave-core
Mar 6, 2018
bridiver
referenced
this pull request
in brave/brave-core
Mar 6, 2018
|
Just tested this on macOS, following the instructions from https://github.com/brave/brave/issues/83#issue-301264707 to set up sccache, and got a compilation error: |
|
I thought I got that same error without sccache as well, but I’ll double-check. In either case the PR just enables sccache again and isn’t meant to address any underlying build issues caused by sccache
… On Mar 6, 2018, at 11:51 AM, Garrett Robinson ***@***.***> wrote:
Just tested this on macOS, following the instructions from #83 (comment) to set up sccache, and got a compilation error:
$ yarn build --debug_build=true --official_build=false
yarn run v1.5.1
$ node ./scripts/commands.js build --debug_build=true --official_build=false
update branding...
building brave...
gn gen /Users/garrettr/brave/src/out/Release --args="root_extra_deps=[\"//brave\"] is_component_build=false proprietary_codecs=true ffmpeg_branding=\"Chrome\" enable_widevine=true target_cpu=\"x64\" is_official_build=false is_debug=false dcheck_always_on=false antimuon_google_api_key=\"AIzaSyAQfxPJiounkhOjODEO5ZieffeBv6yft2Q\" antimuon_google_api_endpoint=\"https://www.googleapis.com/geolocation/v1/geolocate?key=\" antimuon_product_name=\"Brave\" antimuon_project_name=\"brave\" antimuon_version_major=\"1\" antimuon_version_minor=\"0\" antimuon_version_build=\"0\" mac_signing_identifier=\"\" enable_stripping=false symbol_level=2 enable_profiling=true is_win_fastlink=true cc_wrapper=\"/Users/garrettr/brave/src/brave/script/redirect-cc.py\" "
Done. Made 7793 targets from 1481 files in 4120ms
ninja -C /Users/garrettr/brave/src/out/Release brave
ninja: Entering directory `/Users/garrettr/brave/src/out/Release'
[529/29091] CXX obj/components/language/content/browser/language_code_locator/language_code_locator.o
FAILED: obj/components/language/content/browser/language_code_locator/language_code_locator.o
/Users/garrettr/brave/src/brave/script/redirect-cc.py ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/components/language/content/browser/language_code_locator/language_code_locator.o.d -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_XCODE_VERSION=0920 -DCR_CLANG_REVISION=\"321529-2\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../../brave/chromium_src -I../.. -Igen -I../../third_party/s2cellid/src -fno-strict-aliasing -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -fcolor-diagnostics -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -arch x86_64 -Wall -Werror -Wextra -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-tautological-unsigned-zero-compare -Wno-null-pointer-arithmetic -Wno-tautological-constant-compare -Wtautological-constant-out-of-range-compare -O0 -fno-omit-frame-pointer -gdwarf-2 -isysroot ../../../../../../Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk -mmacosx-version-min=10.9.0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=c++14 -stdlib=libc++ -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -c ../../components/language/content/browser/language_code_locator.cc -o obj/components/language/content/browser/language_code_locator/language_code_locator.o
In file included from ../../components/language/content/browser/language_code_locator.cc:8:
In file included from ../../third_party/s2cellid/src/s2/s2cellid.h:28:
../../third_party/s2cellid/src/s2/_fpcontractoff.h:52:14: error: unknown pragma in STDC namespace [-Werror,-Wunknown-pragmas]
#pragma STDC FP_CONTRACT OFF
^
1 error generated.
[538/29091] ACTION //components/resources:about_credits(//build/toolchain/mac:clang_x64)
ninja: build stopped: subcommand failed.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
++ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bridiver commentedMar 6, 2018
No description provided.