Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass brave_channel in env (uplift to 1.7.x) #8970

Merged
merged 1 commit into from Apr 2, 2020

Conversation

@mbacchi
Copy link
Member

mbacchi commented Apr 1, 2020

Uplift of PR #8863 to 1.7.x
Related brave/brave-core#5138

Fixes #8864
Fixes #8896

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@mbacchi mbacchi requested a review from kjozwiak Apr 1, 2020
@mbacchi
Copy link
Member Author

mbacchi commented Apr 1, 2020

The manual build I ran completed successfully with these patches. Info.plist looks accurate.

@mbacchi mbacchi mentioned this pull request Apr 2, 2020
0 of 32 tasks complete
@bsclifton bsclifton changed the title pass brave_channel in env pass brave_channel in env (uplift to 1.7.x) Apr 2, 2020
Copy link
Member

kjozwiak left a comment

Uplift into 1.7.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit c1c4303 into 1.7.x Apr 2, 2020
2 checks passed
2 checks passed
SonarCloud Code Analysis Quality Gate passed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@kjozwiak kjozwiak deleted the fix-mac-crash-reporting-1.7.x branch Apr 2, 2020
@kjozwiak kjozwiak added this to the 1.7.x - Release milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.