Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uplifted ci pipeline changes #9088

Merged
merged 1 commit into from Apr 8, 2020
Merged

uplifted ci pipeline changes #9088

merged 1 commit into from Apr 8, 2020

Conversation

@mihaiplesa
Copy link
Collaborator

mihaiplesa commented Apr 8, 2020

For #8979

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@mihaiplesa mihaiplesa added the CI/skip label Apr 8, 2020
@mihaiplesa mihaiplesa requested review from linhkikuchi and brave/uplift-approvers Apr 8, 2020
@mihaiplesa mihaiplesa self-assigned this Apr 8, 2020
Copy link
Member

kjozwiak left a comment

Uplift into 1.8.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit dff141c into 1.8.x Apr 8, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head The build of this commit was aborted
Details
SonarCloud Code Analysis Quality Gate passed
Details
@kjozwiak kjozwiak deleted the mplesa-ci-pipeline-sync-1.8.x branch Apr 8, 2020
@kjozwiak kjozwiak added this to the 1.8.x - Beta milestone Apr 8, 2020
@kjozwiak kjozwiak added the QA/No label Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.