Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move apks signing on Android to create_dist #9115

Merged
merged 1 commit into from Apr 9, 2020
Merged

Conversation

@SergeyZhukovsky
Copy link
Member

SergeyZhukovsky commented Apr 9, 2020

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@SergeyZhukovsky SergeyZhukovsky added this to the 1.9.x - Nightly milestone Apr 9, 2020
@SergeyZhukovsky SergeyZhukovsky self-assigned this Apr 9, 2020
Copy link
Collaborator

bridiver left a comment

please do a follow-up to remove the android guard and move signApp for all platforms

@SergeyZhukovsky SergeyZhukovsky merged commit 1c8f04b into master Apr 9, 2020
1 check passed
1 check passed
SonarCloud Code Analysis Quality Gate passed
Details
@SergeyZhukovsky SergeyZhukovsky deleted the android_signing branch Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.