Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail on errors #9126

Merged
merged 1 commit into from Apr 10, 2020
Merged

fail on errors #9126

merged 1 commit into from Apr 10, 2020

Conversation

@bridiver
Copy link
Collaborator

bridiver commented Apr 10, 2020

Fixes #9127

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@bridiver bridiver requested review from petemill and linhkikuchi Apr 10, 2020
@bridiver bridiver self-assigned this Apr 10, 2020
@bridiver bridiver added this to the 1.9.x - Nightly milestone Apr 10, 2020
@bridiver bridiver merged commit 591fa12 into master Apr 10, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head This commit is being built
Details
SonarCloud Code Analysis Quality Gate passed
Details
@bridiver bridiver deleted the fail-on-errors branch Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.