Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added signing for android in ci pipeline #9148

Merged
merged 1 commit into from Apr 12, 2020

Conversation

@mihaiplesa
Copy link
Collaborator

mihaiplesa commented Apr 11, 2020

Closes brave/devops#2907

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
Copy link
Member

mbacchi left a comment

++

Copy link
Member

SergeyZhukovsky left a comment

++

@mihaiplesa mihaiplesa merged commit 4864d4e into master Apr 12, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head This commit cannot be built
Details
SonarCloud Code Analysis Quality Gate passed
Details
@mihaiplesa mihaiplesa deleted the mplesa-ci-pipeline-android-signing branch Apr 12, 2020
@bsclifton
Copy link
Member

bsclifton commented Apr 13, 2020

This was pushed into 1.7 with #9156

@mihaiplesa do we need to do for 1.8 also? I believe so - let me know

@mihaiplesa
Copy link
Collaborator Author

mihaiplesa commented Apr 13, 2020

@bsclifton not needed, I pushed directly by mistake

@bsclifton
Copy link
Member

bsclifton commented Apr 13, 2020

@mihaiplesa ok awesome, thanks! 😄 Makes sense why I couldn't find the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.