Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added signing for android in ci pipeline 1.7.x #9156

Merged
merged 1 commit into from Apr 13, 2020

Conversation

@mihaiplesa
Copy link
Collaborator

mihaiplesa commented Apr 12, 2020

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@mihaiplesa mihaiplesa requested a review from SergeyZhukovsky Apr 12, 2020
@mihaiplesa mihaiplesa self-assigned this Apr 12, 2020
@mihaiplesa mihaiplesa changed the title added signing for android in ci pipeline added signing for android in ci pipeline 1.7.x Apr 12, 2020
@mihaiplesa mihaiplesa requested a review from brave/uplift-approvers Apr 12, 2020
Copy link
Member

SergeyZhukovsky left a comment

++

Copy link
Member

bsclifton left a comment

++ LGTM

@bsclifton bsclifton merged commit 3957f9c into 1.7.x Apr 13, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head This commit cannot be built
Details
SonarCloud Code Analysis Quality Gate passed
Details
@bsclifton bsclifton deleted the mplesa-ci-pipeline-android-signing-1.7.x branch Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.