Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Android symbols archive name may have extension now, related … #9214

Closed
wants to merge 1 commit into from

Conversation

@mbacchi
Copy link
Member

mbacchi commented Apr 14, 2020

…to brave-browser#9168"

This reverts commit 01e2f83.

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
…to brave-browser#9168"

This reverts commit 01e2f83.
@mbacchi mbacchi self-assigned this Apr 14, 2020
Copy link
Member

bsclifton left a comment

++

Copy link
Contributor

AlexeyBarabash left a comment

I guess for those PRs which had failed, we must delete brave-browser branch and restart CI job.
PRs for renamning symbols are both in b-b and b-c and it is required to have them both (#9175, brave/brave-core#5233)

I marked as changes are requested just to block this PR until we would try with removing b-b branch.

@mihaiplesa
Copy link
Collaborator

mihaiplesa commented Apr 15, 2020

Not needed, original code works, just needs rebase on b-b.

@mihaiplesa mihaiplesa closed this Apr 15, 2020
@mihaiplesa mihaiplesa deleted the revert_armclassic branch Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.