Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate to use our new Chromium mirror (uplift to 1.7) #9304
Conversation
|
Trying to fix git cache on servers first (to avoid needing this)- let's not merge this please |
|
Closing as I believe I found a fix. See https://bravesoftware.slack.com/archives/CA5FPHWLF/p1587189601497800 for more information |
simplify init/sync and make them compatible with GIT_CACHE_DIR
|
Windows ran into a problem during init. Other platforms look OK
https://ci.brave.com/job/brave-browser-build-pr/job/PR-9304/3/execution/node/245/log/ |
|
why are we uplifting this? |
|
it would need this as well #9343 and I don't think we've had this in master long enough to uplift it |
|
Closing out in favor of a smaller PR, similar to #9359 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bsclifton commentedApr 17, 2020
•
edited
Includes the following (merged in this order)