Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If `src` remote hasn't been set yet, don't override with the Chromium repo #9309

Closed
wants to merge 1 commit into from

Conversation

@bsclifton
Copy link
Member

bsclifton commented Apr 18, 2020

Before src is initialized as a git repo, it inherits the remote from the parent folder

Fixes #9308

Submitter Checklist:

Test Plan:

  1. Do fresh clone
  2. Run npm run init
  3. Verify remote for root isn't set to the Chromium one

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@bsclifton bsclifton added this to the 1.9.x - Nightly milestone Apr 18, 2020
@bsclifton bsclifton requested review from bridiver and linhkikuchi Apr 18, 2020
@bsclifton bsclifton self-assigned this Apr 18, 2020
@bsclifton
Copy link
Member Author

bsclifton commented Apr 20, 2020

Closing in favor of #9142

@bsclifton bsclifton closed this Apr 20, 2020
@bsclifton bsclifton deleted the bsc-fix-remote branch Apr 20, 2020
@bsclifton bsclifton removed this from the 1.9.x - Nightly milestone Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.