Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify safe browsing label #9411

Merged
merged 1 commit into from Apr 27, 2020
Merged

Modify safe browsing label #9411

merged 1 commit into from Apr 27, 2020

Conversation

@simonhong
Copy link
Collaborator

simonhong commented Apr 23, 2020

Fix #9266

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@simonhong simonhong added this to the 1.10.x - Nightly milestone Apr 23, 2020
@simonhong simonhong requested a review from bsclifton Apr 23, 2020
@simonhong simonhong self-assigned this Apr 23, 2020
@simonhong simonhong mentioned this pull request Apr 23, 2020
7 of 32 tasks complete
@simonhong simonhong force-pushed the fix_safe_browing_label branch 2 times, most recently from e2d861a to 05cfa2a Apr 23, 2020
Fixup safe browsing label in privacy settings page.
We have to modify these sentences explicitly because we replaces
upstream sentences that including Google or Safe Browsing.
@bsclifton bsclifton force-pushed the fix_safe_browing_label branch from 05cfa2a to a27ed2d Apr 24, 2020
Copy link
Member

bsclifton left a comment

++

@simonhong simonhong merged commit 441a813 into master Apr 27, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head This commit has test failures
Details
SonarCloud Code Analysis Quality Gate passed
Details
@simonhong simonhong deleted the fix_safe_browing_label branch Apr 27, 2020
simonhong added a commit that referenced this pull request Apr 27, 2020
Modify safe browsing label
simonhong added a commit that referenced this pull request Apr 27, 2020
Modify safe browsing label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.