Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed slash escaping in branch name #9585

Merged
merged 1 commit into from May 2, 2020
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -129,8 +129,9 @@ def checkAndAbortBuild() {
}

def startBraveBrowserBuild() {
PIPELINE_NAME = "pr-brave-browser-" + BRAVE_BROWSER_BRANCH.replace('/', '-')
jobDsl(scriptText: """
pipelineJob("pr-brave-browser-${BRAVE_BROWSER_BRANCH}") {
pipelineJob("${PIPELINE_NAME}") {
// this list has to match the parameters in the Jenkinsfile from devops repo
parameters {
choiceParam("CHANNEL", ["nightly", "dev", "beta", "release", "development"])
@@ -197,5 +198,5 @@ def startBraveBrowserBuild() {
string(name: "BRANCH_PRODUCTIVITY_DESCRIPTION", value: BRANCH_PRODUCTIVITY_DESCRIPTION),
string(name: "BRANCH_PRODUCTIVITY_USER", value: BRANCH_PRODUCTIVITY_USER)
]
currentBuild.result = build(job: "pr-brave-browser-${BRAVE_BROWSER_BRANCH}", parameters: params, propagate: false).result
currentBuild.result = build(job: PIPELINE_NAME, parameters: params, propagate: false).result
}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.