Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd build_delta_installer option to create_dist #9667
Conversation
| @@ -482,6 +487,11 @@ Config.prototype.update = function (options) { | |||
| this.skip_signing = true | |||
| } | |||
|
|
|||
| if (options.build_delta_installer) { | |||
| this.build_delta_installer = true | |||
| this.last_chrome_installer = options.last_chrome_installer | |||
This comment has been minimized.
This comment has been minimized.
bridiver
May 13, 2020
•
Collaborator
I think we should be checking this for a non-empty value instead of just assuming it exists. Presumably it should be an error if build_delta_installer === true && last_chrome_installer === null ?
This comment has been minimized.
This comment has been minimized.
bridiver
May 13, 2020
Collaborator
or is there a default value we should be providing here? https://github.com/brave/brave-browser/pull/9667/files#diff-1bb8ffaf71730e8067757db1a6a153dbR85
This comment has been minimized.
This comment has been minimized.
simonhong
May 14, 2020
Author
Collaborator
Right, last_chrome_installer should have args for building delta installer.
Added assert here - https://github.com/brave/brave-browser/pull/9667/files#diff-f7bf2b665273dfa66ffa4ad7c0a52bb9R197.
It doesn't make sense to try to build delta installer w/o last_chrome_installer args.
To generate delta installer, pass true to build_delta_installer and pass folder that includes previous versions chrome.7z file to last_chrome_installer. This folder should be in out dir. For example, if we want to delta folder for it, create delta folder to out/Release/delta and copies chrome.7z to it. and pass "delta" to last_chrome_installer. During the build, couregette.exe wiil be copired to that folder.
simonhong commentedMay 7, 2020
•
edited
To generate delta installer, pass true to build_delta_installer and
pass folder that includes previous versions chrome.7z file to
last_chrome_installer. This folder should be in out dir.
For example, if we want to delta folder for it, create delta folder
to out/Release/delta and copies chrome.7z to it. and pass "delta"
to last_chrome_installer. During the build, couregette.exe will be
copied to that folder.
Issue #9565
Submitter Checklist:
git rebase master(if needed).git rebase -ito squash commits (if needed).added to
scripts/audit.js.Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.