Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Upgrade from Chromium 81 to Chromium 83 #9765

Open
wants to merge 7 commits into
base: master
from
Open

WIP: Upgrade from Chromium 81 to Chromium 83 #9765

wants to merge 7 commits into from
+22 −6

Conversation

@mkarolin
Copy link
Contributor

mkarolin commented May 13, 2020 •
edited

Fixes #9760
Related PR: brave/brave-core#5102

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
@mkarolin mkarolin self-assigned this May 13, 2020
@mkarolin mkarolin mentioned this pull request May 13, 2020
Open
0 of 32 tasks complete
@mkarolin mkarolin marked this pull request as ready for review May 13, 2020
@mkarolin mkarolin requested a review from bridiver as a code owner May 13, 2020
@bridiver
bridiver reviewed May 13, 2020
View changes
lib/test.js
@@ -39,6 +39,11 @@ const test = (suite, buildConfig = config.defaultBuildConfig, options) => {
// Build the tests
util.run('ninja', ['-C', config.outputDir, suite], config.defaultOptions)

const run_brave_rewards_unitests = suite === 'brave_unit_tests' && config.targetOS !== 'ios'

This comment has been minimized.

Sign in to view
Copy link
@bridiver

bridiver May 13, 2020

Collaborator

we don't want to do this here, it should all be in gn
mkarolin and others added 6 commits Mar 26, 2020
@mkarolin
Upgrade from Chromium 81.0.4044.138 to Chromium 83.0.4103.56.
52d6e0e
@mkarolin
Pin b-c branch
eaddccb
@mkarolin
is_win_fastlink build arg was removed.
174f480 
Chromium change:

https://chromium.googlesource.com/chromium/src/+/108dc9210ea25e593ad8139763ee1e1665752f96

commit 108dc9210ea25e593ad8139763ee1e1665752f96
Author: Nico Weber <thakis@chromium.org>
Date:   Tue Feb 25 17:25:32 2020 +0000

    win: Remove is_win_fastlink arg.

    It only has an effect when not using clang and lld, and the default
    build setup is to use clang and lld. Also, goma has dropped support
    for non-clang compiles, and a main use case for is_win_fastlink
    was being able to use goma. Finally, is_win_fastlink never worked
    well.

    Bug: 1053958
@samartnik @mkarolin
[Android] Fix for dark mode colors
73ef04f
@mkarolin
Split rewards/ads unit tests into a separate suite.
f8d2235 
When all unit test are in the same suite, all the -D and -I add up to a
command line that is too long on Windows.
@mkarolin
iOS doesn't use brave_services_key.
Loading status checks…
667669e
@mkarolin
iOS doesn't use webcompat_report_api_endpoint.
Loading status checks…
97bce8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver

At least 1 approving review is required to merge this pull request.

Assignees

@mkarolin mkarolin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Upgrade from Chromium 81 to Chromium 83
3 participants
@mkarolin @bridiver @samartnik
You can’t perform that action at this time.