Skip to content

/ brave-core-crx-packager

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically determine the HTTPSE version to use from latest XPI #22

Closed
bbondy opened this issue Sep 6, 2018 · 1 comment
Closed

Automatically determine the HTTPSE version to use from latest XPI #22

bbondy opened this issue Sep 6, 2018 · 1 comment
Assignees
@emerick

Comments

@bbondy
Copy link
Member

@bbondy bbondy commented Sep 6, 2018

Cross posting from https-everywhere-builder because I think we're likely to miss it there if we don't track it here.

https-everywhere-builder has xpiVersion in it at path scripts/preloadHTTPSE.js.
We should extract the XPI (zip) and take the manifest.json's version instead.

brave/https-everywhere-builder#7
@fmarier
Copy link
Member

@fmarier fmarier commented Aug 15, 2019

The original issue was resolved in brave/https-everywhere-builder#12 and is the recommended approach suggested by EFF.
@fmarier fmarier closed this Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@fmarier @bbondy @emerick
You can’t perform that action at this time.