Skip to content

/ brave-core-crx-packager

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove quoting binary for generateCRXFile so command runs on macOS #26

Closed
bbondy opened this issue Oct 3, 2018 · 0 comments
Closed

Remove quoting binary for generateCRXFile so command runs on macOS #26

bbondy opened this issue Oct 3, 2018 · 0 comments
Assignees
@bbondy

Comments

@bbondy
Copy link
Member

@bbondy bbondy commented Oct 3, 2018

No description provided.

@bbondy bbondy self-assigned this Oct 3, 2018
bbondy added a commit that referenced this issue Oct 3, 2018
@bbondy
Remove quoting binary for generateCRXFile so command runs on macOS
4177410 
Fix #26
@bbondy bbondy mentioned this issue Oct 3, 2018
Merged
bbondy added a commit that referenced this issue Oct 3, 2018
@bbondy
Remove quoting binary for generateCRXFile so command runs on macOS
a5d28ea 
On Windows you'll need to do something disgusting like this for now:
npm run package-themes -- --keys-directory keys --binary \""C:\Program Files (x86)\Google\Chrome\Application\chrome.exe\"" --endpoint http://localhost:8000

Fix #26
@bbondy bbondy closed this in #27 Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@bbondy
You can’t perform that action at this time.