Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upScript to upload CRX file shouldn't require version number parameter #8
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When we package a CRX file, we require the user to specify a version number via
--set-version. This makes sense, as themanifest.jsonrequires a version number.However, our upload script also requires the
--set-versionparameter. This seems redundant and error-prone (it's easy to make a typo and specify a version number that doesn't match the version number in the CRX'smanifest.json). Instead of requiring the user to pass--set-versionwhen uploading, we should just unzip the CRX to a temporary directory and parse the version number out of itsmanifest.json.