Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to upload CRX file shouldn't require version number parameter #8

Closed
emerick opened this issue Aug 1, 2018 · 0 comments
Closed

Script to upload CRX file shouldn't require version number parameter #8

emerick opened this issue Aug 1, 2018 · 0 comments
Assignees
Labels

Comments

@emerick
Copy link
Contributor

@emerick emerick commented Aug 1, 2018

When we package a CRX file, we require the user to specify a version number via --set-version. This makes sense, as the manifest.json requires a version number.

However, our upload script also requires the --set-version parameter. This seems redundant and error-prone (it's easy to make a typo and specify a version number that doesn't match the version number in the CRX's manifest.json). Instead of requiring the user to pass --set-version when uploading, we should just unzip the CRX to a temporary directory and parse the version number out of its manifest.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.