Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd client model parameter updates #105
Merged
Conversation
moritzhaller
force-pushed the
client-model-parameter-updater
branch
from
57d9fd3
to
4ab452e
|
++ LGTM! I can't vouch for the new functionality introduced, but the added npm tasks won't interfere with anything |
|
LGTM with nits. |
|
|
||
| createParameterUpdateJsonFile(jsonFilePath, JSON.stringify(modelsData)) | ||
|
|
||
| // Download image files that specified in models.json |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
thanks @bsclifton new functionality is under construction ;) |
moritzhaller
force-pushed the
client-model-parameter-updater
branch
from
4ab452e
to
177c917
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moritzhaller commentedApr 1, 2020
•
edited
unblock brave/brave-browser#8396