Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove vault-updater-path option, which is no longer needed #31
Conversation
S3 upload is now done here, which eliminates the release-tools dependency.
|
cc @mihaiplesa I think you might need to update the jenkins jobs to remove this command line param. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emerick commentedOct 19, 2018
Fixes #30
Eliminates the
--vault-updater-pathoption from our scripts, since it's no longer needed. Dropping the option itself was simple, but release-tools had a lot of assumptions about vault-updater baked in. Seemed easiest to just drop release-tools as a dependency and migrate the S3 upload code (essentially just a single function) to our utility script.