Skip to content

/ brave-core-crx-packager

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct S3 options and brave-core-specific bucket #33

Merged
merged 1 commit into from Oct 22, 2018
Merged

Use correct S3 options and brave-core-specific bucket #33

merged 1 commit into from Oct 22, 2018

Conversation

@emerick
Copy link
Contributor

emerick commented Oct 22, 2018

Fixes #32
@emerick
Use correct S3 options and brave-core-specific bucket
a791f05
@emerick emerick self-assigned this Oct 22, 2018
@emerick emerick requested a review from bbondy Oct 22, 2018
@emerick
Copy link
Contributor Author

emerick commented Oct 22, 2018

cc: @mihaiplesa
@mihaiplesa
Copy link

mihaiplesa commented Oct 22, 2018

looking good
@emerick emerick requested a review from mihaiplesa Oct 22, 2018
@mihaiplesa
mihaiplesa approved these changes Oct 22, 2018
View changes
Copy link

mihaiplesa left a comment

let's go!
@bbondy
bbondy approved these changes Oct 22, 2018
View changes
@emerick emerick merged commit 2d8dd52 into master Oct 22, 2018
@emerick emerick deleted the fix-s3-upload branch Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy

@mihaiplesa mihaiplesa

Assignees

@emerick emerick

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@emerick @mihaiplesa @bbondy
You can’t perform that action at this time.