Skip to content

/ brave-core-crx-packager

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps to work with node 11 #38

Merged
merged 1 commit into from Jan 8, 2019
Merged

Update deps to work with node 11 #38

merged 1 commit into from Jan 8, 2019

Conversation

@bbondy
Copy link
Member

bbondy commented Jan 7, 2019

Fix #37

I also did a fresh update of package-lock.json
@bbondy
Update deps to work with node 11
bef5e67 
Fix #37
@bbondy bbondy self-assigned this Jan 7, 2019
@bbondy bbondy requested review from emerick, pilgrim-brave and mihaiplesa Jan 7, 2019
@bbondy
Copy link
Member Author

bbondy commented Jan 7, 2019

cc @mihaiplesa if this lands we need to use node 11 for the crx packager then make sure they still update successfully by running each jenkins job please.
@emerick
emerick approved these changes Jan 7, 2019
View changes
Copy link
Contributor

emerick left a comment

LGTM
@pilgrim-brave
pilgrim-brave approved these changes Jan 7, 2019
View changes
Copy link
Contributor

pilgrim-brave left a comment

LGTM2
@mihaiplesa
mihaiplesa approved these changes Jan 8, 2019
View changes
Copy link

mihaiplesa left a comment

ready to roll
@bbondy bbondy merged commit 4907057 into master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaiplesa mihaiplesa

@emerick emerick

@pilgrim-brave pilgrim-brave

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@bbondy @mihaiplesa @emerick @pilgrim-brave
You can’t perform that action at this time.