Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 48: ExtensionWhitelist should use the default manifest #49

Merged
merged 1 commit into from Mar 11, 2019

Conversation

@jumde
Copy link
Contributor

jumde commented Mar 11, 2019

fix #48

Description

Local-Data extension was failing the build with this error:

13:57:34 
13:57:35 Unhandled rejection: { Error: ENOENT: no such file or directory, open 'manifests/local-data-files-updater/ExtensionWhitelist-manifest.json'
13:57:35     at Object.openSync (fs.js:450:3)
13:57:35     at Object.readFileSync (fs.js:350:35)
13:57:35     at Object.parseManifest (/Users/jenkins/jenkins/workspace/brave-core-ext-local-data-files-update-publish-dev/lib/util.js:77:19)
13:57:35     at processDATFile (/Users/jenkins/jenkins/workspace/brave-core-ext-local-data-files-update-publish-dev/scripts/packageComponent.js:121:31)
13:57:35     at Array.forEach (<anonymous>)
13:57:35     at util.createTableIfNotExists.then (/Users/jenkins/jenkins/workspace/brave-core-ext-local-data-files-update-publish-dev/scripts/packageComponent.js:163:6)

The ExtensionWhitelist should use the default manifest and not ExtensionWhitelist-manifest

@jumde jumde self-assigned this Mar 11, 2019
@jumde jumde requested review from mihaiplesa, emerick and pilgrim-brave Mar 11, 2019
Copy link
Contributor

emerick left a comment

LGTM

@jumde jumde merged commit ca66762 into master Mar 11, 2019
@bsclifton bsclifton deleted the fix_local_data_extension_build branch Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.